Add IntLogicalTypeAnnotation in parquet writer #18301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows reader implementations to potentially produce smaller in-memory representations when reading data or skip bound checks from reading INT32 as smaller types
sopel39
approved these changes
Jul 17, 2023
| if (INTEGER.equals(type) || SMALLINT.equals(type) || TINYINT.equals(type)) { | ||
| return Types.primitive(PrimitiveType.PrimitiveTypeName.INT32, repetition).named(name); | ||
| // https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#signed-integers | ||
| // INT(32, true) and INT(64, true) are implied by the int32 and int64 primitive types if no other annotation is present. |
There was a problem hiding this comment.
Do we need to test is against databricks or hive?
There was a problem hiding this comment.
TestHiveCompatibility and TestHiveSparkCompatibility test hive/spark reading files written by trino.
Worst case other readers should ignore this annotation and behave as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows reader implementations to potentially produce smaller in-memory representations
when reading data or skip bound checks from reading INT32 as smaller types.
Also useful for schema discovery tools to infer byte/short types from parquet INT32 types with annotation.
Additional context and related issues
https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#signed-integers
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: