Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operate on column handle directly in checkPartitionTypesSupported and other cleanups #18316

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 17, 2023

Avoid converting to metastore Column when checking for supported and unsupported types. This avoids a lookup in TypeManager.

Extracted from #18315

Avoid converting to metastore Column when checking for supported and
unsupported types. This avoids a lookup in `TypeManager`.
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jul 17, 2023
@findepi findepi requested review from wendigo and raunaqmorarka July 17, 2023 19:33
@cla-bot cla-bot bot added the cla-signed label Jul 17, 2023
@github-actions github-actions bot added tests:hive hive Hive connector labels Jul 17, 2023
@github-actions github-actions bot added the iceberg Iceberg connector label Jul 17, 2023
@findepi findepi changed the title Operate on column handle directly in checkPartitionTypesSupported Operate on column handle directly in checkPartitionTypesSupported and other cleanups Jul 17, 2023
@findepi findepi merged commit b4f0a33 into trinodb:master Jul 18, 2023
@findepi findepi deleted the findepi/operate-on-column-handle-directly-in-checkpartitiontypessupported-8bc3cc branch July 18, 2023 19:17
@github-actions github-actions bot added this to the 423 milestone Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector iceberg Iceberg connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants