Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support predicate pushdown on char and decimal type in mongodb #18382

Merged
merged 3 commits into from
Aug 8, 2023
Merged

Support predicate pushdown on char and decimal type in mongodb #18382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee0d9c4
Support predicate pushdown on char type in mongodb
krvikash Jul 24, 2023
ab2161f
Support predicate pushdown on decimal type in mongodb
krvikash Jul 24, 2023
5b050ea
Test testPredicatePushdown against comparison operator in mongodb
krvikash Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@
import io.trino.spi.predicate.Domain;
import io.trino.spi.predicate.Range;
import io.trino.spi.predicate.TupleDomain;
import io.trino.spi.type.CharType;
import io.trino.spi.type.DecimalType;
import io.trino.spi.type.Decimals;
import io.trino.spi.type.Int128;
import io.trino.spi.type.IntegerType;
import io.trino.spi.type.NamedTypeSignature;
import io.trino.spi.type.RowFieldName;
Expand All @@ -61,6 +65,7 @@
import io.trino.spi.type.VarcharType;
import org.bson.Document;
import org.bson.types.Binary;
import org.bson.types.Decimal128;
import org.bson.types.ObjectId;

import java.time.Instant;
Expand Down Expand Up @@ -90,6 +95,7 @@
import static io.trino.spi.HostAddress.fromParts;
import static io.trino.spi.type.BigintType.BIGINT;
import static io.trino.spi.type.BooleanType.BOOLEAN;
import static io.trino.spi.type.Chars.padSpaces;
import static io.trino.spi.type.DateTimeEncoding.unpackMillisUtc;
import static io.trino.spi.type.DateType.DATE;
import static io.trino.spi.type.DoubleType.DOUBLE;
Expand Down Expand Up @@ -665,10 +671,22 @@ private static Optional<Object> translateValue(Object trinoNativeValue, Type typ
return Optional.of(trinoNativeValue);
}

if (type instanceof DecimalType decimalType) {
if (decimalType.isShort()) {
return Optional.of(Decimal128.parse(Decimals.toString((long) trinoNativeValue, decimalType.getScale())));
}
return Optional.of(Decimal128.parse(Decimals.toString((Int128) trinoNativeValue, decimalType.getScale())));
}

if (type instanceof ObjectIdType) {
return Optional.of(new ObjectId(((Slice) trinoNativeValue).getBytes()));
}

if (type instanceof CharType charType) {
Slice slice = padSpaces(((Slice) trinoNativeValue), charType);
return Optional.of(slice.toStringUtf8());
}

if (type instanceof VarcharType) {
return Optional.of(((Slice) trinoNativeValue).toStringUtf8());
}
Expand Down
8 changes: 7 additions & 1 deletion plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/TypeUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
package io.trino.plugin.mongodb;

import com.google.common.collect.ImmutableSet;
import io.trino.spi.type.CharType;
import io.trino.spi.type.DecimalType;
import io.trino.spi.type.Type;
import io.trino.spi.type.VarcharType;

Expand Down Expand Up @@ -52,6 +54,10 @@ public static boolean isJsonType(Type type)

public static boolean isPushdownSupportedType(Type type)
{
return type instanceof VarcharType || type instanceof ObjectIdType || PUSHDOWN_SUPPORTED_PRIMITIVE_TYPES.contains(type);
return type instanceof CharType
|| type instanceof VarcharType
|| type instanceof DecimalType
|| type instanceof ObjectIdType
|| PUSHDOWN_SUPPORTED_PRIMITIVE_TYPES.contains(type);
}
}
81 changes: 79 additions & 2 deletions plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,8 +327,12 @@ public void testExplainAnalyzeWithDeleteWithSubquery()
public void testPredicatePushdown(String value)
{
try (TestTable table = new TestTable(getQueryRunner()::execute, "test_predicate_pushdown", "AS SELECT %s col".formatted(value))) {
assertThat(query("SELECT * FROM " + table.getName() + " WHERE col = " + value + ""))
.isFullyPushedDown();
testPredicatePushdown(table.getName(), "col = " + value);
testPredicatePushdown(table.getName(), "col != " + value);
testPredicatePushdown(table.getName(), "col < " + value);
testPredicatePushdown(table.getName(), "col > " + value);
testPredicatePushdown(table.getName(), "col <= " + value);
testPredicatePushdown(table.getName(), "col >= " + value);
}
}

Expand All @@ -341,7 +345,10 @@ public Object[][] predicatePushdownProvider()
{"smallint '2'"},
{"integer '3'"},
{"bigint '4'"},
{"decimal '3.14'"},
{"decimal '1234567890.123456789'"},
{"'test'"},
{"char 'test'"},
{"objectid('6216f0c6c432d45190f25e7c')"},
{"date '1970-01-01'"},
{"time '00:00:00.000'"},
Expand All @@ -350,6 +357,76 @@ public Object[][] predicatePushdownProvider()
};
}

@Test
public void testPredicatePushdownCharWithPaddedSpace()
{
try (TestTable table = new TestTable(
getQueryRunner()::execute,
"test_predicate_pushdown_char_with_padded_space",
"(k, v) AS VALUES" +
" (-1, CAST(NULL AS char(3))), " +
" (0, CAST('' AS char(3)))," +
" (1, CAST(' ' AS char(3))), " +
" (2, CAST(' ' AS char(3))), " +
" (3, CAST(' ' AS char(3)))," +
" (4, CAST('x' AS char(3)))," +
" (5, CAST('x ' AS char(3)))," +
" (6, CAST('x ' AS char(3)))," +
" (7, CAST('\0' AS char(3)))," +
" (8, CAST('\0 ' AS char(3)))," +
" (9, CAST('\0 ' AS char(3)))")) {
assertThat(query("SELECT k FROM " + table.getName() + " WHERE v = ''"))
// The value is included because both sides of the comparison are coerced to char(3)
.matches("VALUES 0, 1, 2, 3")
.isFullyPushedDown();
assertThat(query("SELECT k FROM " + table.getName() + " WHERE v = 'x '"))
// The value is included because both sides of the comparison are coerced to char(3)
.matches("VALUES 4, 5, 6")
.isFullyPushedDown();
assertThat(query("SELECT k FROM " + table.getName() + " WHERE v = '\0 '"))
// The value is included because both sides of the comparison are coerced to char(3)
.matches("VALUES 7, 8, 9")
.isFullyPushedDown();
}
}

@Test
public void testHighPrecisionDecimalPredicate()
{
try (TestTable table = new TestTable(
getQueryRunner()::execute,
"test_high_precision_decimal_predicate",
"(col DECIMAL(34, 0))",
Arrays.asList("decimal '3141592653589793238462643383279502'", null))) {
// Filter clause with 38 precision decimal value
String predicateValue = "decimal '31415926535897932384626433832795028841'";
assertThat(query("SELECT * FROM " + table.getName() + " WHERE col = " + predicateValue))
// With EQUAL operator when column type precision is less than the predicate value's precision,
// PushPredicateIntoTableScan#pushFilterIntoTableScan returns ValuesNode. So It is not possible to verify isFullyPushedDown.
.returnsEmptyResult();
testPredicatePushdown(table.getName(), "col != " + predicateValue);
testPredicatePushdown(table.getName(), "col < " + predicateValue);
testPredicatePushdown(table.getName(), "col > " + predicateValue);
testPredicatePushdown(table.getName(), "col <= " + predicateValue);
testPredicatePushdown(table.getName(), "col >= " + predicateValue);

// Filter clause with 34 precision decimal value
predicateValue = "decimal '3141592653589793238462643383279502'";
testPredicatePushdown(table.getName(), "col = " + predicateValue);
testPredicatePushdown(table.getName(), "col != " + predicateValue);
testPredicatePushdown(table.getName(), "col < " + predicateValue);
testPredicatePushdown(table.getName(), "col > " + predicateValue);
testPredicatePushdown(table.getName(), "col <= " + predicateValue);
testPredicatePushdown(table.getName(), "col >= " + predicateValue);
}
}

private void testPredicatePushdown(String tableName, String whereClause)
{
assertThat(query("SELECT * FROM " + tableName + " WHERE " + whereClause))
.isFullyPushedDown();
}

@Test
public void testJson()
{
Expand Down