Disable task level writer scaling from TableExecute #18388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav8297
force-pushed
the
disable_scaling_table_execute
branch
from
bb6e2ce to
29db74d
Compare
core/trino-main/src/main/java/io/trino/sql/planner/optimizations/AddLocalExchanges.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
Show resolved
Hide resolved
gaurav8297
force-pushed
the
disable_scaling_table_execute
branch
from
29db74d to
8536820
Compare
core/trino-main/src/main/java/io/trino/sql/planner/optimizations/AddLocalExchanges.java
Show resolved
Hide resolved
gaurav8297
force-pushed
the
disable_scaling_table_execute
branch
from
8536820 to
c06d835
Compare
raunaqmorarka
approved these changes
Jul 24, 2023
gaurav8297
force-pushed
the
disable_scaling_table_execute
branch
from
c06d835 to
0f6a774
Compare
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
...ng/trino-product-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergOptimize.java
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
| assertUpdate("INSERT INTO " + tableName + " VALUES 10", 1); | ||
| assertUpdate("INSERT INTO " + tableName + " VALUES 20", 1); | ||
| assertUpdate("INSERT INTO " + tableName + " VALUES NULL", 1); | ||
| assertUpdate("ALTER TABLE " + tableName + " EXECUTE OPTIMIZE"); | ||
| assertUpdate(Session.builder(getQueryRunner().getDefaultSession()) | ||
| .setSystemProperty("task_writer_count", "1") |
There was a problem hiding this comment.
Instead of setting this session property, can we instead adjust the assertions for the increased file count ?
There was a problem hiding this comment.
I think we should explicitly set the value of task_writer_count. This makes the test more reliable.
github-actions
bot
added
iceberg
It can result in smaller files than file_size_threshold, which can be undesirable behaviour.
gaurav8297
force-pushed
the
disable_scaling_table_execute
branch
from
0f6a774 to
4acf294
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, task writer scaling can lead to file sizes which are not controlled via OPTIMIZE command thus making it unreliable.
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: