Remove uses of Slice not backed by byte[] #18461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
iceberg
lib/trino-parquet/src/main/java/io/trino/parquet/reader/decoders/DeltaPackingUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/main/java/io/trino/parquet/reader/decoders/DeltaPackingUtils.java
Outdated
Show resolved
Hide resolved
Merged
|
Slice 2.0 is ready so we will proceed with the (slightly) larger that finishes completes the transition to Slice 2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch all code to only create Slice with a byte[]. This is the proposed direction of Slice as it will vastly simplify the Slice code, allow the conversion to VarHandles, and ensures that Slice based code will be monomorphic.
Release notes
( ) This is not user-visible or docs only and no release notes are required.