Remove duplicate logic for create/update Iceberg table in metastore #18500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AbstractMetastoreTableOperations.commitNewTable` sets `comment` table parameter. Update it on table changes too.
Deduplicate logic for `AbstractMetastoreTableOperations.commitNewTable` and `commitToExistingTable` for updating metastore `Table` from Iceberg `TableMetadata`.
findepi
added
the
no-release-notes
github-actions
bot
added
tests:hive
iceberg
The previous name was a left-over from previous implementation attempt.
findepi
force-pushed
the
findepi/iceberg-moperations
branch
from
e177613 to
dbf6d8e
Compare
ebyhr
approved these changes
Aug 3, 2023
|
I assume this is just a code cleanup and refactor with no bug fix or performance improvement aspect to add to the release notes @findepi |
|
@mosabua Right, this PR contains |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.