Support reading time millis columns in optimized parquet #18535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
approved these changes
Aug 4, 2023
Comment on lines
+331
to
+332
| // decoded values are millis, round to lower precision and convert to picos | ||
| // modulo PICOSECONDS_PER_DAY is applied for the case when a value is rounded up to PICOSECONDS_PER_DAY |
There was a problem hiding this comment.
should we have similar rounding for getTimeMicrosDecoder where trino type is lower than precision than 6?
(or assertion that type is 6 if only time(6) is supported)
There was a problem hiding this comment.
Yes, I'm planning to tackle that separately by adding rounding on lower precision. In practise we're only supporting time(6) in iceberg right now, so it's not a problem yet. But from parquet reader perspective it is better to assume such a scenario might arise in future and support it correctly.
lib/trino-parquet/src/test/java/io/trino/parquet/reader/FileParquetDataSource.java
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/reader/TestingColumnReader.java
Outdated
Show resolved
Hide resolved
lib/trino-parquet/src/test/java/io/trino/parquet/reader/TestingColumnReader.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
pqr-time-int32
branch
from
a01e4dd to
657bbfc
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per parquet spec https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#time Time(MILLIS) stored as INT32 is a valid parquet encoding. Such a file can be produced by parquet-cpp-arrow and should be possible to read as time(6) from iceberg.
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: