Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundant code in procedure declarations #18569

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 7, 2023

No description provided.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Aug 7, 2023
@findepi findepi requested review from dain, ebyhr, kokosing and hashhar August 7, 2023 12:50
@cla-bot cla-bot bot added the cla-signed label Aug 7, 2023
findepi added 2 commits August 7, 2023 14:50
Make the procedure be declared as other procedures.
It is probably unused since f09ccea.
@github-actions github-actions bot added tests:hive iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector labels Aug 7, 2023
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll re-read the 2nd last commit, rest looks good.

@findepi
Copy link
Member Author

findepi commented Aug 8, 2023

@findepi findepi requested a review from hashhar August 8, 2023 09:26
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@findepi findepi merged commit 5062ed1 into master Aug 8, 2023
@findepi findepi deleted the findepi/boil branch August 8, 2023 10:44
@github-actions github-actions bot added this to the 423 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

2 participants