Don't build upstream dependencies with errorprone #18598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing this in nineinchnick#15 |
|
This is not effective because properties can't override plugin configuration, per GIB docs:
|
nineinchnick
force-pushed
the
skip-errorprone-downstream
branch
2 times, most recently
from
2323ddd to
ad0aa6f
Compare
|
Looks like it works now: vs an earlier run: |
findepi
reviewed
Aug 9, 2023
findepi
reviewed
Aug 9, 2023
findepi
reviewed
Aug 9, 2023
Errorprone is only needed to impacted modules, not all dependencies.
nineinchnick
force-pushed
the
skip-errorprone-downstream
branch
from
ad0aa6f to
1c55d9d
Compare
nineinchnick
changed the title
findepi
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Errorprone is only needed to impacted modules, not all
dependencies.
Additional context and related issues
https://trinodb.slack.com/archives/CP1MUNEUX/p1691199541970659
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: