Fix Hive write to bucketed table when native writers disabled #18672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
requested review from
electrum,
raunaqmorarka,
sopel39,
ebyhr and
kokosing
losipiuk
reviewed
Aug 14, 2023
| @@ -32,6 +32,7 @@ | |||
| import io.trino.filesystem.Location; | |||
| import io.trino.filesystem.TrinoFileSystem; | |||
| import io.trino.filesystem.TrinoFileSystemFactory; | |||
| import io.trino.filesystem.TrinoOutputFile; | |||
There was a problem hiding this comment.
Can you make commit summary of Fix Hive write to bucketed table when native writers disabled Reverts "Use Hive native writers for creating empty bucket files" - so it is obvious this is a single commit revert.
Add context why it is reverted later in commit message
There was a problem hiding this comment.
I am following the pattern from #18612
The revert commit is clearly marked as such in the message, but not in the title.
Here, I didn't expand in the commit body on why I revert, because it's all in the title/summary line.
losipiuk
approved these changes
Aug 14, 2023
This reverts commit a794b32.
`TestHiveConnectorTest.testWithAllStorageFormats` is supposed to exercise format configurations, including different reader/writer implementations. For example it exercised two Parquet writers until 1339286 when one was removed. This commit adds same improved test coverage for other file formats which have two execution paths.
findepi
force-pushed
the
findepi/native-bucket
branch
from
8ba5a4e to
2f1e8ec
Compare
|
rebased after #18669 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18667
Based on #18669, only two last commits should be reviewed here.