Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Event listeners from main docs navigation #18707

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Remove Event listeners from main docs navigation #18707

merged 1 commit into from
Aug 16, 2023

Conversation

ryandoowan
Copy link
Contributor

@ryandoowan ryandoowan commented Aug 16, 2023 •
edited by mosabua
Loading

Description

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Aug 16, 2023
@mosabua mosabua requested a review from electrum August 16, 2023 20:42
mosabua
mosabua approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This removes the top level left hand navigation item for event listeners and just nests it in admin .. like we already do for security and others.

@mosabua
Copy link
Member

mosabua commented Aug 16, 2023

Any concerns with merging this @electrum or @arhimondr ?

@mosabua
Copy link
Member

mosabua commented Aug 16, 2023 •
edited
Loading

Please update commit message to

"Remove Event listeners from main docs navigation

@ryandoowan ryandoowan changed the title Fix nav event listener Remove Event listeners from main docs navigation Aug 16, 2023
@github-actions github-actions bot added the docs label Aug 16, 2023
@mosabua mosabua merged commit d80be15 into trinodb:master Aug 16, 2023
@mosabua
Copy link
Member

mosabua commented Aug 16, 2023

Thanks @ryandoowan and @electrum

@github-actions github-actions bot added this to the 424 milestone Aug 16, 2023
@colebow colebow mentioned this pull request Aug 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@electrum electrum electrum approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
424
Development

Successfully merging this pull request may close these issues.
3 participants
@ryandoowan @mosabua @electrum