Support reading negative zero in MongoDB #18777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashhar
reviewed
Aug 23, 2023
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoPageSource.java
Show resolved
Hide resolved
ebyhr
commented
Aug 23, 2023
| else { | ||
| BigDecimal result = decimal.bigDecimalValue(); | ||
| type.writeObject(output, Decimals.encodeScaledValue(result, decimalType.getScale())); | ||
| } |
There was a problem hiding this comment.
I didn't touch guessFieldType method because the precision and scale are still unclear in the case of negative zero.
hashhar
approved these changes
Aug 24, 2023
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mongodb-decimal128-negative-zero
branch
from
3a31ee9 to
2717958
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) Release notes are required, with the following suggested text: