Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if DELETE pushdown write operation is feasible #18789

Conversation

findinpath
Copy link
Contributor

Description

Fix for issue introduced by #18332

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 24, 2023
@findinpath findinpath requested a review from ebyhr August 24, 2023 05:51
@github-actions github-actions bot added the delta-lake Delta Lake connector label Aug 24, 2023
@ebyhr
Copy link
Member

ebyhr commented Aug 24, 2023

Could you fix the following failures as well?

Error:    TestDeltaLakeFileOperations.testDeleteWholePartition:173->assertFileSystemAccesses:358 Expected: 
		1 fewer occurrences of FileOperation[fileType=LAST_CHECKPOINT, fileId=_last_checkpoint, operationType=INPUT_FILE_NEW_STREAM],
		1 fewer occurrences of FileOperation[fileType=TRANSACTION_LOG_JSON, fileId=00000000000000000003.json, operationType=INPUT_FILE_NEW_STREAM]
Error:    TestDeltaLakeFileOperations.testDeleteWholeTable:201->assertFileSystemAccesses:358 Expected: 
		1 fewer occurrences of FileOperation[fileType=LAST_CHECKPOINT, fileId=_last_checkpoint, operationType=INPUT_FILE_NEW_STREAM],
		1 fewer occurrences of FileOperation[fileType=TRANSACTION_LOG_JSON, fileId=00000000000000000003.json, operationType=INPUT_FILE_NEW_STREAM]

@findinpath findinpath force-pushed the findinpath/check-write-possible-on-delete-pushdown branch from 910a2e2 to f83da42 Compare August 24, 2023 07:25
@ebyhr ebyhr merged commit f44e828 into trinodb:master Aug 24, 2023
@github-actions github-actions bot added this to the 425 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector
Development

Successfully merging this pull request may close these issues.

2 participants