-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add S3 region configuration to security mapping #18838
Conversation
8700b33
to
4e309d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using the security mapping feature to change endpoint and region is a misuse IMO.
The correct solution is to use different catalogs IMO.
@electrum your opinion?
I do agree that would be ideal. But I think there are valid use-cases for this feature. For example, our user has tables with data from many different buckets each needing their own VPC endpoints. Using a single catalog gives us a unified querying experience and doesn't require us enforcing users to make sure they're using the correct catalog. |
I think this is reasonable. The feature is really “flexible S3 configuration” and not just security. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
👋 @kekwan could you rebase this PR so we can continue review and get to merge potentially. |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(X) Release notes are required, with the following suggested text: