-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docker-images version to 89 #19564
Conversation
030ca0f
to
047eb31
Compare
4442d4c
to
8ef931f
Compare
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Outdated
Show resolved
Hide resolved
|
Probably, we should burn docker-images 88. It throws NoClassDefFoundError when inserting rows into Avro table. |
8ef931f
to
ef4d6e6
Compare
Any idea about this failure?
|
c644ce3
to
25302f4
Compare
...roduct-tests/src/main/java/io/trino/tests/product/iceberg/TestIcebergSparkCompatibility.java
Outdated
Show resolved
Hide resolved
@@ -149,6 +149,7 @@ databases: | |||
spark: | |||
host: spark | |||
jdbc_driver_class: org.apache.hive.jdbc.HiveDriver | |||
jdbc_jar: /docker/jdbc/hive-jdbc.jar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this now?
org.apache.hive.jdbc.HiveDriver
in hive-jdbc.jar
is same as on the classpath
trino/testing/trino-product-tests-launcher/pom.xml
Lines 188 to 200 in 8969ecf
<dependency> | |
<groupId>org.apache.hive</groupId> | |
<artifactId>hive-jdbc</artifactId> | |
<version>3.1.3</version> | |
<classifier>standalone</classifier> | |
<scope>runtime</scope> | |
<exclusions> | |
<exclusion> | |
<groupId>*</groupId> | |
<artifactId>*</artifactId> | |
</exclusion> | |
</exclusions> | |
</dependency> |
trino/testing/trino-product-tests-launcher/pom.xml
Lines 302 to 309 in 8969ecf
<artifactItem> | |
<groupId>org.apache.hive</groupId> | |
<artifactId>hive-jdbc</artifactId> | |
<classifier>standalone</classifier> | |
<type>jar</type> | |
<outputDirectory>${project.build.directory}</outputDirectory> | |
<destFileName>hive-jdbc.jar</destFileName> | |
</artifactItem> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trino-product-tests
module contains another Hive JDBC driver. New Hive JDBC driver doesn't work with old Hive servers if I remember correctly. I'm losing the context of this PR. This comment might be wrong.
<dependency>
<groupId>io.trino.hive</groupId>
<artifactId>hive-apache-jdbc</artifactId>
<scope>runtime</scope>
</dependency>
66c5a68
to
78a603b
Compare
ddc5c98
to
cbc1c7a
Compare
20fda90
to
dd7de3b
Compare
6135fc2
to
6a607fa
Compare
onSpark().executeQuery(format("INSERT INTO %s PARTITION(dt='-0001-01-01') VALUES (6)", sparkTableName)); | ||
|
||
assertThat(onTrino().executeQuery("SELECT \"$partition\" FROM " + trinoTableName)) | ||
assertThat(onTrino().executeQuery("SELECT value, \"$partition\" FROM " + trinoTableName)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added value
column to distinguish the partition values.
6a607fa
to
655e8db
Compare
Description
Relates to trinodb/docker-images#184
Fixes #17562
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.