Remove redundant classloader wrapper from table functions #20184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Engine-provided functions do not need `ClassLoaderSafeConnectorTableFunction` wrapper.
Engine-provided functions do not need `ClassLoaderSafeConnectorTableFunction` wrapper.
findepi
added
the
no-release-notes
findepi
commented
Dec 20, 2023
| import static java.util.Locale.ENGLISH; | ||
| import static java.util.stream.Collectors.joining; | ||
|
|
||
| public class ExcludeColumnsFunction |
There was a problem hiding this comment.
This is not a new code. It just became a top level class (a rename from ExcludeColumns.ExcludeColumnsFunction to ExcludeColumnsFunction, no need for Provider).
| { | ||
| return new ClassLoaderSafeConnectorTableFunction(new SequenceFunction(), getClass().getClassLoader()); | ||
| super( |
There was a problem hiding this comment.
This is not a new code. It just became a top level class (a rename from Sequence.SequenceFunction to SequenceFunction, no need for Provider).
Nice that github shows this as a rename. Review ignoring whitespace changes to see a small diff.
raunaqmorarka
approved these changes
Dec 21, 2023
|
CI #16315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Engine-provided functions do not need
ClassLoaderSafeConnectorTableFunctionwrapper.