Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dropping corrupted tables to Iceberg Nessie Catalog #20360

Merged

Conversation

emmanuel099
Copy link
Contributor

Description

PR #16674 added support for dropping corrupted Iceberg tables but the Nessie catalog implementation was missing.

Similar as done in the Glue catalog implementation, we load the metadata location from Nessie and extract the table location from it. This allows us to drop the directory where the Iceberg table is located in.

Additional context and related issues

This is a follow up of #16674

Release notes

This is not user-visible or is docs only, and no release notes are required.

Copy link

cla-bot bot commented Jan 12, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Emmanuel Pescosta.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@emmanuel099 emmanuel099 force-pushed the iceberg_nessie_drop_corrupted_table branch from 4c5c503 to a8f77f7 Compare January 12, 2024 14:10
Copy link

cla-bot bot commented Jan 12, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the iceberg Iceberg connector label Jan 12, 2024
@ebyhr
Copy link
Member

ebyhr commented Jan 20, 2024

Please fix CI failure and submit CLA.

@emmanuel099 emmanuel099 force-pushed the iceberg_nessie_drop_corrupted_table branch from a8f77f7 to d142d8a Compare January 23, 2024 10:40
Copy link

cla-bot bot commented Jan 23, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@emmanuel099
Copy link
Contributor Author

Please fix CI failure and submit CLA.

Thanks, CI should be fixed now. I have already sent the signed CLA to cla@trino.io on Jan 14, 2024.

@ebyhr
Copy link
Member

ebyhr commented Jan 31, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 31, 2024
Copy link

cla-bot bot commented Jan 31, 2024

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr ebyhr force-pushed the iceberg_nessie_drop_corrupted_table branch from d142d8a to 6761b8f Compare January 31, 2024 07:08
@ebyhr ebyhr merged commit 08f5d31 into trinodb:master Jan 31, 2024
40 of 43 checks passed
@github-actions github-actions bot added this to the 438 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector
Development

Successfully merging this pull request may close these issues.

2 participants