Replace custom air.main.basedir property with built-in session.rootDirectory

[nineinchnick]

Description

session.rootDirectory was introduced in Maven 3.9

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

[nineinchnick]

It doesn't work with the Modernizer plugin and I'm not sure why.

[cstamas]

This is a good PR, but modernizer needs a circumvention as described above.

[cstamas]

This is a good PR, but modernizer needs a circumvention as described above.

[wendigo]

@nineinchnick nice

[cstamas]

com.github.ekryd.sortpom:sortpom-maven-plugin:3.3.0:verify (default) on project trino-testing-services: The file /home/runner/work/trino/trino/testing/trino-testing-services/pom.xml is not sorted

So edits did violate some rules, needs reformat?

[nineinchnick]

com.github.ekryd.sortpom:sortpom-maven-plugin:3.3.0:verify (default) on project trino-testing-services: The file /home/runner/work/trino/trino/testing/trino-testing-services/pom.xml is not sorted

So edits did violate some rules, needs reformat?

This tripped on empty <properties></properties> tags, I removed them.

[cstamas]

More sortpom issues:
com.github.ekryd.sortpom:sortpom-maven-plugin:3.3.0:verify (default) on project trino-phoenix5-patched: The file /home/runner/work/trino/trino/lib/trino-phoenix5-patched/pom.xml is not sorted

[findepi]

Per airbase docs

For a multi-module project, all other sub-modules must have this explicitly set to the root directory and therefore the following code

<properties>
  <air.main.basedir>${project.parent.basedir}</air.main.basedir>
</properties>

must be added to each pom.

https://github.com/airlift/airbase/blob/master/README.md#airmainbasedir

so when using airbase root pom, we are expected to define the air.main.basedir property correctly, and this should not be removed

howeever, airbase seems to make no direct use of air.main.basedir property, so we may perhaps simply remove it from airbase (remove from airbase pom and readme). this would be a prep step, if we're pedantic.

[nineinchnick]

this would be a prep step, if we're pedantic.

Oh, but we are!

[wendigo]

I like the fact that we are making POMs smaller :)

[wendigo]

@nineinchnick do you plan a follow-up in Airbase to remove this property?