Prevent view owner from being set when system security is used #20647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homar
force-pushed
the
homar/dont_set_owner_for_glue_view_when_using_system_security
branch
from
4908d1d to
3ef8da1
Compare
alexjo2144
approved these changes
Feb 14, 2024
Did you mean "materialized view"? |
findepi
reviewed
Feb 15, 2024
| throws IOException | ||
| { | ||
| Path rootPath = Files.createTempDirectory("test_iceberg_mv_with_glue"); | ||
| TrinoCatalog glueTrinoCatalog = createGlueTrinoCatalog(false, true, new LocalFileSystemFactory(rootPath)); |
There was a problem hiding this comment.
HDFS_FILE_SYSTEM_FACTORY should work ok for local files, just use file:// url
this will avoid adding TrinoFileSystemFactory parameter in createTrinoCatalog overload, keeping things simpler
|
/test-with-secrets sha=3ef8da1423497723a0d38d90eeef49727f103c33 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/7912829622 |
homar
force-pushed
the
homar/dont_set_owner_for_glue_view_when_using_system_security
branch
from
3ef8da1 to
b075e78
Compare
|
/test-with-secrets sha=b075e781b70d455c037742cc9d5d9f13d9b30d0b |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/7920785518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is a security hole as user can have broader access to glue than to trino and can leverage this to get access to data he should not access
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: