Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand MV doc around grace period #20665

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Feb 12, 2024

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 12, 2024
@github-actions github-actions bot added the docs label Feb 12, 2024
@mosabua mosabua changed the title Mv grace Expand MV doc around grace period Feb 12, 2024
@mosabua mosabua requested a review from findepi February 12, 2024 18:57
Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple wording tweaks

docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/create-materialized-view.md Outdated Show resolved Hide resolved
@mosabua
Copy link
Member Author

mosabua commented Feb 12, 2024

Rejigged this all some more @findepi @colebow

Copy link
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final nit then LGTM

docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
Copy link
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed, lgtm.

@martint may want to take a look

@mosabua mosabua force-pushed the mv-grace branch 3 times, most recently from a71e318 to 5777a57 Compare February 14, 2024 23:48
@mosabua
Copy link
Member Author

mosabua commented Feb 14, 2024

Can you review again @colebow and @findepi .. I adjusted quite a bit after I chatted with @martint

@mosabua
Copy link
Member Author

mosabua commented Feb 21, 2024

Ping @colebow @findepi and @martint

docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/create-materialized-view.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/sql/create-materialized-view.md Outdated Show resolved Hide resolved
Co-authored-by: Cole Bowden <104291808+colebow@users.noreply.github.com>
@mosabua
Copy link
Member Author

mosabua commented Feb 28, 2024

I did another round of checks and I think this is good to go.

@mosabua mosabua merged commit e173bb5 into trinodb:master Feb 28, 2024
3 checks passed
@mosabua mosabua deleted the mv-grace branch February 28, 2024 21:53
@github-actions github-actions bot added this to the 440 milestone Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants