Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HTTP client config doc #20690

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update HTTP client config doc #20690

merged 1 commit into from
Feb 16, 2024

Conversation

mosabua
Copy link
Member

@mosabua mosabua commented Feb 13, 2024

Description

  • Add exchange prefix
  • Add max content length property

This came up to be added in some discussion around exchange.http-client.max-content-length
so I think it makes sense to add it to the list.

However ... I am not sure if we want to add this property specifically as well. In the prior PR with @Jessie212 I think we decided NOT to add that property, but it seems to be used in the field.

Additional context and related issues

#12247

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@mosabua mosabua changed the title Add exchange menttion to HTTP client props Add exchange mention to HTTP client props Feb 14, 2024
@mosabua mosabua changed the title Add exchange mention to HTTP client props Add exchange HTTP client config doc Feb 15, 2024
@mosabua mosabua changed the title Add exchange HTTP client config doc Update HTTP client config doc Feb 15, 2024
@mosabua mosabua requested a review from Jessie212 February 15, 2024 19:05
Copy link
Contributor

@Jessie212 Jessie212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit change requested.

docs/src/main/sphinx/admin/properties-exchange.md Outdated Show resolved Hide resolved
- Add exchange prefix
- Add max content length property
@mosabua mosabua merged commit bae265a into trinodb:master Feb 16, 2024
8 checks passed
@mosabua mosabua deleted the exchange branch February 16, 2024 01:56
@github-actions github-actions bot added this to the 440 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants