Add varchar to char coercion for hive tables #20723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
requested review from
ebyhr,
krvikash,
findinpath,
vlad-lyutenko and
marcinsbd
findinpath
reviewed
Feb 15, 2024
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/CoercionUtils.java
Show resolved
Hide resolved
findinpath
reviewed
Feb 15, 2024
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestVarcharToCharCoercer.java
Show resolved
Hide resolved
findinpath
reviewed
Feb 15, 2024
plugin/trino-hive/src/test/java/io/trino/plugin/hive/coercions/TestVarcharToCharCoercer.java
Show resolved
Hide resolved
findinpath
reviewed
Feb 15, 2024
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/BaseTestHiveCoercion.java
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/varchar_to_char_coercer
branch
from
9549533 to
789bb71
Compare
Praveen2112
force-pushed
the
praveen/varchar_to_char_coercer
branch
from
789bb71 to
c0babc4
Compare
|
@findinpath Thanks a lot for your review. AC |
findinpath
reviewed
Feb 16, 2024
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/BaseTestHiveCoercion.java
Show resolved
Hide resolved
findinpath
approved these changes
Feb 16, 2024
marcinsbd
approved these changes
Feb 16, 2024
krvikash
approved these changes
Feb 19, 2024
Praveen2112
force-pushed
the
praveen/varchar_to_char_coercer
branch
2 times, most recently
from
642e185 to
ecc78fd
Compare
Praveen2112
force-pushed
the
praveen/varchar_to_char_coercer
branch
from
ecc78fd to
b0014c5
Compare
|
Updated a few test cases wrt to whitespace |
kokosing
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add varchar to char coercion for hive tables.
Enable the Hive users to retrieve the information from their tables after performing queries which change varchar/ string columns to float.
Hive sample DDL query:
ALTER TABLE mytable CHANGE COLUMN mycolumn mycolumn char(4);
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: