Use RPM builder instead of redlinerpm #20727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
force-pushed
the
serafin/rpm-builder
branch
from
276edcd to
9dba887
Compare
nineinchnick
approved these changes
Feb 16, 2024
core/trino-server-rpm/src/test/java/io/trino/server/rpm/ServerIT.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/rpm-builder
branch
from
9dba887 to
822bbb9
Compare
|
I've added a bunch of tests to assert on both metadata and RPM content |
nineinchnick
approved these changes
Feb 16, 2024
electrum
approved these changes
Feb 16, 2024
|
This is great! I'm happy we can deprecate our fork of the RPM plugin |
wendigo
force-pushed
the
serafin/rpm-builder
branch
2 times, most recently
from
6c5a07c to
4697457
Compare
It has superior configuration abilities and is a little faster (30 vs 45s on average).
wendigo
force-pushed
the
serafin/rpm-builder
branch
from
4697457 to
aa113b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has superior configuration abilities and is a little faster (30 vs 45s on average).
https://ctron.github.io/rpm-builder/rpm-mojo.html
https://github.com/ctron/rpm-builder