Mark new tasks readyForScheduling when fragment children are finished #20736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
added
the
no-release-notes
dekimir
approved these changes
Feb 16, 2024
| @@ -109,6 +109,7 @@ | |||
| import it.unimi.dsi.fastutil.ints.IntOpenHashSet; | |||
| import it.unimi.dsi.fastutil.ints.IntSet; | |||
| import jakarta.annotation.Nullable; | |||
| import jakarta.ws.rs.HEAD; | |||
There was a problem hiding this comment.
Can you help me understand why this new import is necessary?
There was a problem hiding this comment.
:)
This is artifact of IntelliJ doing automatic imports. And conflict resolition with
HEAD <<<<<<<<<<<
makers
Makes isReadyForExecution() resilient to changes in estimate classification.
Previously, StageExecution#updatePartition() always created new tasks as speculative. But if the fragment's children are completed, the task is not really speculative -- it can get scheduled without fear of its precursors failing.
findepi
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.