Remove deprecation from Standard environment extender #20745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The suggested replacement, the `StandardMultinode`, relies on `Standard`, so we cannot remove the class. It also provides number of constants shared across. Having it deprecated triggers many warnings in the code, with no clear intention to have them resolved.
findepi
added
test
no-release-notes
wendigo
approved these changes
Feb 19, 2024
findepi
deleted the
findepi/remove-deprecation-from-standard-environment-extender-dbd52d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggested replacement, the
StandardMultinode, relies onStandard, so we cannot remove the class. It also provides number of constants shared across. Having it deprecated triggers many warnings in the code, with no clear intention to have them resolved.