Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update <description>s in modules #20773

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Update <description>s in modules #20773

merged 2 commits into from
Feb 20, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Feb 20, 2024

No description provided.

@wendigo wendigo requested a review from electrum February 20, 2024 15:57
@cla-bot cla-bot bot added the cla-signed label Feb 20, 2024
@wendigo wendigo requested review from martint and mosabua February 20, 2024 15:57
mosabua
mosabua requested changes Feb 20, 2024
View reviewed changes
client/trino-jdbc/pom.xml Outdated Show resolved Hide resolved
core/trino-parser/pom.xml Outdated Show resolved Hide resolved
core/trino-spi/pom.xml Outdated Show resolved Hide resolved
lib/trino-array/pom.xml Outdated Show resolved Hide resolved
lib/trino-matching/pom.xml Outdated Show resolved Hide resolved
plugin/trino-teradata-functions/pom.xml Outdated Show resolved Hide resolved
testing/trino-faulttolerant-tests/pom.xml Outdated Show resolved Hide resolved
testing/trino-test-jdbc-compatibility-old-driver/pom.xml Outdated Show resolved Hide resolved
testing/trino-test-jdbc-compatibility-old-server/pom.xml Outdated Show resolved Hide resolved
testing/trino-testing-resources/pom.xml Outdated Show resolved Hide resolved
@github-actions github-actions bot added docs jdbc Relates to Trino JDBC driver tests:hive hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector labels Feb 20, 2024
@wendigo wendigo force-pushed the serafin/pom-descriptions branch from f383e94 to 5b24d95 Compare February 20, 2024 17:20
@wendigo wendigo requested a review from mosabua February 20, 2024 17:20
@wendigo
Copy link
Contributor Author

wendigo commented Feb 20, 2024

@mosabua all addressed

@wendigo wendigo force-pushed the serafin/pom-descriptions branch from 5b24d95 to df0a2cb Compare February 20, 2024 17:23
mosabua
mosabua approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mosabua
Copy link
Member

mosabua commented Feb 20, 2024

Wondering if we should do a similar thing for URL and link to relevant docs. Probably cant enforce that though since some stuff doesnt have docs.

@wendigo wendigo force-pushed the serafin/pom-descriptions branch from df0a2cb to 505e70d Compare February 20, 2024 17:30
@wendigo
Copy link
Contributor Author

wendigo commented Feb 20, 2024

@mosabua we can both enforce it, and add links to poms

@wendigo wendigo force-pushed the serafin/pom-descriptions branch from 505e70d to 2afaf92 Compare February 20, 2024 18:13
@wendigo wendigo merged commit aba685c into master Feb 20, 2024
98 of 103 checks passed
@wendigo wendigo deleted the serafin/pom-descriptions branch February 20, 2024 20:39
@github-actions github-actions bot added this to the 440 milestone Feb 20, 2024
@colebow colebow mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mosabua mosabua mosabua approved these changes

@electrum electrum Awaiting requested review from electrum

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
bigquery BigQuery connector cla-signed delta-lake Delta Lake connector docs hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver mongodb MongoDB connector
Milestone
440
Development

Successfully merging this pull request may close these issues.
2 participants
@wendigo @mosabua