Test tracing cleanup #20781
Merged
Test tracing cleanup #20781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests:hive
iceberg
wendigo
approved these changes
Feb 21, 2024
martint
reviewed
Feb 21, 2024
| @@ -65,6 +67,8 @@ public final class StandaloneQueryRunner | |||
| private final InMemorySpanExporter spanExporter = InMemorySpanExporter.create(); | |||
|
|
|||
| private final ReadWriteLock lock = new ReentrantReadWriteLock(); | |||
| private final AtomicInteger concurrentQueries = new AtomicInteger(); | |||
| private boolean spansValid = true; | |||
There was a problem hiding this comment.
What guards accesses to this non-volatile field?
There was a problem hiding this comment.
good point.
i can make it volatile, but it doesn't make this bullet proof anyway.
so conceptually this field is used normally in single-threaded scenario only (the only scenario where it's legit to run query and then ask for spans).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.