Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pattern for Flaky ACID tests #20826

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented Feb 23, 2024

Description

Exception message changed and currently tests are not retrying with warning:

WARNING: not retrying; stacktrace does not match pattern 'Hive table .* is corrupt. Found sub-directory in bucket directory for partition': [io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: Query failed (#20240221_201727_00799_jrn62): Found file in sub-directory of ACID directory: hdfs://hadoop-master:9000/user/hive/warehouse/test_read_full_acid_true_none_p7a1xz1629/part_col=2/delete_delta_0000002_0000005/delete_delta_0000002_0000005/bucket_00000

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, the test you're marking flaky was not marked before.

So did the error message change for all tests or just this one?

(Stupid question but I don't know).

LGTM otherwise.

@pajaks
Copy link
Member Author

pajaks commented Feb 23, 2024

So did the error message change for all tests or just this one?

It changed for all tests.

@hashhar hashhar merged commit 01b7c38 into trinodb:master Feb 26, 2024
42 checks passed
@github-actions github-actions bot added this to the 440 milestone Feb 26, 2024
@pajaks pajaks self-assigned this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants