Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application default credentials to GcsStorageFactory #20827

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

elonazoulay
Copy link
Member

This enables the use of workload identity federation.

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

This enables the use of workload identity federation.
@findepi findepi requested a review from findinpath February 23, 2024 10:59
Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, so we can probably do same in BigQuery connector too I guess?

@ebyhr
Copy link
Member

ebyhr commented Feb 27, 2024

I think we already do the same thing in BigQuery connector?

return GoogleCredentials.getApplicationDefault(factory.getTransportOptions().getHttpTransportFactory());

@ebyhr ebyhr merged commit b90fe09 into trinodb:master Feb 27, 2024
57 of 59 checks passed
@github-actions github-actions bot added this to the 440 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants