Clarify semantics for Trino filesystem #20847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Feb 28, 2024
|
|
||
| import static io.trino.memory.context.AggregatedMemoryContext.newSimpleAggregatedMemoryContext; | ||
|
|
||
| public interface TrinoOutputFile | ||
| { | ||
| /** | ||
| * Create file exclusively, failing if the file already exists. For file systems which do not |
There was a problem hiding this comment.
"Create file exclusively, failing or overwriting if the file already exists."
| @@ -45,6 +52,12 @@ default void createExclusive(Slice content) | |||
| createExclusive(content, newSimpleAggregatedMemoryContext()); | |||
| } | |||
|
|
|||
| /** | |||
| * Create file exclusively, failing if the file already exists. For file systems which do not | |||
There was a problem hiding this comment.
"Create file exclusively, failing or overwriting if the file already exists."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clarify semantics for Trino filesystem.
Additional context and related issues
See discussion on Slack: https://trinodb.slack.com/archives/CP1MUNEUX/p1708958482815419
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.