Revamp planning of pattern recognition #20853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
ir-patternmatching
branch
from
08b2fd3 to
dd1d796
Compare
martint
force-pushed
the
ir-patternmatching
branch
from
dd1d796 to
410423b
Compare
dain
approved these changes
Feb 28, 2024
core/trino-main/src/main/java/io/trino/sql/analyzer/ExpressionAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/PatternRecognitionAnalysis.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/PatternRecognitionAnalysis.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/PatternRecognitionAnalysis.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/LocalExecutionPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/RelationPlanner.java
Outdated
Show resolved
Hide resolved
The frame end expression was being pre-projected so that it could be rewritten into a symbol reference, as that's the only type of expression WindowNode supports. When the frame end is a constant and a measure expression contains the same constant, it gets extracted and rewritten as a symbol reference withing the measure expression. This is unnecessary at best and a performance issue in the worst case.
martint
force-pushed
the
ir-patternmatching
branch
from
410423b to
3df84ae
Compare
Move all analysis tasks to the analyzer and remove artificial intermediate pseudo-IR.
martint
force-pushed
the
ir-patternmatching
branch
from
3df84ae to
bdc17dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all analysis tasks to the analyzer and remove artificial intermediate pseudo-IR.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.