Build CreateWriteStream lazily in BigQuery #20857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
added
the
no-release-notes
ebyhr
force-pushed
the
ebi/bigquery-lazy-create-writer-stream
branch
from
e4dbeb5 to
7fe9fec
Compare
ebyhr
changed the title
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/bigquery-lazy-create-writer-stream
branch
2 times, most recently
from
2bafe41 to
ef36f34
Compare
wendigo
reviewed
Feb 28, 2024
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/BigQueryPageSink.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/bigquery-lazy-create-writer-stream
branch
from
ef36f34 to
4ea2b0e
Compare
wendigo
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build CreateWriteStream lazily for avoiding the rate limit.
Currently, INSERT with single row creates 6 CreateWriteStream and it leads to rate limits.