-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TrinoOutputFile.create javadoc #20867
Fix TrinoOutputFile.create javadoc #20867
Conversation
@@ -53,7 +53,7 @@ default void createExclusive(Slice content) | |||
} | |||
|
|||
/** | |||
* Create file exclusively, failing if the file already exists. For file systems which do not | |||
* Create file exclusively, failing or overwriting f the file already exists. For file systems which do not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dangling f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @wendigo , fixed
The semantics are slightly different. This won't affect how caller use create() because currently we don't have a way to check is the underlying FS support it or not. However, this will affect how someone who tried to implement a FS in the future.
I went thought all the implementations and they all follow the former semantic. I don't think it is necessary to loose the restriction. I don't recommend this change.
|
@oneonestar i think i am correcting the first sentence of the javadoc only. |
ac36a4f
to
f12f582
Compare
No description provided.