Cleanup test containers on retries #20902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method was returning one thing and setting a field with another.
Container start may fail and leave a container running behind. When container creation/start is not retried, this is not an issue, since the failure is propagated and leads to test failures anyway. If creation/start is retried, the leaked container may be running in the background (resource leak), and also will be reported by `ReportLeakedContainers` (test failure, even though the start was retried and successful in the end). Therefore containers needs to be explicitly cleaned up (stopped) upon retries.
findepi
added
test
no-release-notes
hashhar
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container start may fail and leave a container running behind.
When container creation/start is not retried, this is not an issue,
since the failure is propagated and leads to test failures anyway.
If creation/start is retried, the leaked container may be running in the
background (resource leak), and also will be reported by
ReportLeakedContainers(test failure, even though the start wasretried and successful in the end). Therefore containers needs to be
explicitly cleaned up (stopped) upon retries.