Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry in HTTP client for Thrift metastore #20951

Merged
merged 3 commits into from
Mar 6, 2024

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Mar 6, 2024

Description

Support OpenTelemetry in HTTP client for Thrift metastore
Apache HttpClient 5 instrumentation was added in https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/tag/v2.1.0

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Mar 6, 2024
@cla-bot cla-bot bot added the cla-signed label Mar 6, 2024
@ebyhr ebyhr requested review from wendigo, vihangk1 and findinpath March 6, 2024 01:18
@github-actions github-actions bot added tests:hive hive Hive connector labels Mar 6, 2024
@ebyhr ebyhr self-assigned this Mar 6, 2024
Base automatically changed from serafin/airbase-151 to master March 6, 2024 01:35
@wendigo
Copy link
Contributor

wendigo commented Mar 6, 2024

@ebyhr airbase 151 updated opentelemetry so you want to rebase that PR. Just to double check

@wendigo
Copy link
Contributor

wendigo commented Mar 6, 2024

Nvm. It was based off my branch. Thanks!

Copy link
Member

@vihangk1 vihangk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebyhr ebyhr merged commit e9d2561 into master Mar 6, 2024
66 checks passed
@ebyhr ebyhr deleted the ebi/hive-otel-http branch March 6, 2024 02:54
@github-actions github-actions bot added this to the 440 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants