Lazy computation of some fields in QueryMetadata and QueryStatistics #21445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Computation of QueryMetadata#payload and QueryStatistics#operatorSummaries is a heavy operation. This change causes that they will be computated at most once for multiple event listeners and computation will be lazy - most event listeners do not need this kind of information.
sopel39
approved these changes
Apr 9, 2024
wendigo
approved these changes
Apr 9, 2024
|
pt (default, suite-cassandra, ) cannot pass, since the PT server artifact already expired |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QueryCompletedEventonly once, even if there is multiple event listeners.QueryMetadata#paylaodandQueryStatistics#operatorSummarieslazily because of heaviness (CPU and memory) of these computation.Motivation
A lot of CPU cycles released
Fixes a regression introduced in 7f30476 (#12968) --
QueryCompletedEventwas being created multiple times, and it's sometimes quite expensive.Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: