Fix error location markers for SQL routines #21815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
force-pushed
the
fix-inline-function
branch
from
d8c23d9 to
d28609e
Compare
electrum
changed the title
electrum
force-pushed
the
fix-inline-function
branch
2 times, most recently
from
b789eb4 to
8529fc0
Compare
findepi
reviewed
May 6, 2024
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineAnalyzer.java
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/routine/SqlRoutineAnalyzer.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
May 6, 2024
core/trino-main/src/main/java/io/trino/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/CreateFunctionTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/LanguageFunctionManager.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/AbstractTestEngineOnlyQueries.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
|
thanks for fixing this |
martint
reviewed
May 6, 2024
core/trino-main/src/test/java/io/trino/sql/query/TestInlineFunctions.java
Outdated
Show resolved
Hide resolved
electrum
force-pushed
the
fix-inline-function
branch
from
8529fc0 to
52bfee1
Compare
electrum
force-pushed
the
fix-inline-function
branch
from
52bfee1 to
cb1d102
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21357
Release notes
(x) Release notes are required, with the following suggested text: