change client_info column_type to MEDIUMTEXT #23427
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@cla-bot check |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
The cla-bot has been summoned, and re-checked this pull request! |
| @@ -32,7 +32,7 @@ public interface QueryDao | |||
| " trace_token VARCHAR(255) NULL,\n" + | |||
| " remote_client_address VARCHAR(255) NULL,\n" + | |||
| " user_agent VARCHAR(255) NULL,\n" + | |||
| " client_info VARCHAR(255) NULL,\n" + | |||
| " client_info MEDIUMTEXT NULL,\n" + | |||
There was a problem hiding this comment.
But how would perform migration - In case of older tables which has this column as a VARCHAR(255)
There was a problem hiding this comment.
I think for both this and the DB resource groups we rely on users manually managing the schema. There are no migrations.
Introducing migrations is a bigger task here and with how less often the changes happen here I think it's fine to skip for now.
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Fixes #22362
Changed the column data-type for
client_infofromvarchar(255)toMEDIUMTEXTin mysql event listener. This will allow for a larger payload to be stored, and is also inline with other columns(possibly big) in the table.Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( X ) Release notes are required, with the following suggested text: