Improve ClickHouse LIKE pushdown for complex expression #23591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
Praveen2112
approved these changes
Sep 27, 2024
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
ssheikin
force-pushed
the
ssheikin/49/trino/clickhouse-varchar-LIKE-pushdown
branch
from
e8ebf9b to
53c2599
Compare
|
@ssheikin Can we rebase it on top of the master ? |
ssheikin
force-pushed
the
ssheikin/49/trino/clickhouse-varchar-LIKE-pushdown
branch
from
53c2599 to
a241bb8
Compare
ssheikin
force-pushed
the
ssheikin/49/trino/clickhouse-varchar-LIKE-pushdown
branch
from
a241bb8 to
93d99d9
Compare
Praveen2112
reviewed
Sep 27, 2024
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
Praveen2112
reviewed
Sep 27, 2024
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
Praveen2112
reviewed
Sep 27, 2024
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
Praveen2112
reviewed
Sep 30, 2024
...n/trino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
Outdated
Show resolved
Hide resolved
ssheikin
force-pushed
the
ssheikin/49/trino/clickhouse-varchar-LIKE-pushdown
branch
2 times, most recently
from
20b6509 to
e20b82f
Compare
Praveen2112
reviewed
Sep 30, 2024
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
ssheikin
force-pushed
the
ssheikin/49/trino/clickhouse-varchar-LIKE-pushdown
branch
from
e20b82f to
e5e958c
Compare
Praveen2112
approved these changes
Sep 30, 2024
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Outdated
Show resolved
Hide resolved
ssheikin
force-pushed
the
ssheikin/49/trino/clickhouse-varchar-LIKE-pushdown
branch
from
e5e958c to
01859be
Compare
Praveen2112
approved these changes
Oct 1, 2024
plugin/trino-clickhouse/src/main/java/io/trino/plugin/clickhouse/expression/RewriteLike.java
Show resolved
Hide resolved
ssheikin
deleted the
ssheikin/49/trino/clickhouse-varchar-LIKE-pushdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves ClickHouse LIKE pushdown for complex expressions in Trino.
LIKE with ESCAPE is out of scope of this PR.
Trino syntax for LIKE without ESCAPE does not support escape characters.
However Clickhouse supports escape with \ is for escaping literals %, _ and .
When Trino LIKE pattern contains \ do not pushdown the expression to Clickhouse.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: