Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more BCrypt versions #23668

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Oct 3, 2024

Fixes #23648

Description

Additional context and related issues

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text:

## Security
* Add support for BCrypt 2A, 2B, 2X versions ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Oct 3, 2024
@wendigo wendigo requested review from martint, electrum and dain October 3, 2024 20:09
@wendigo wendigo force-pushed the serafin/support-more-bcrypt-versions branch from 05bdad2 to 76b95d8 Compare October 3, 2024 20:29
@wendigo wendigo requested a review from losipiuk October 3, 2024 20:39
Copy link
Member

@dain dain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just working on this also. Your version is much better than mine.

@wendigo wendigo merged commit c9da5cd into master Oct 4, 2024
52 checks passed
@wendigo wendigo deleted the serafin/support-more-bcrypt-versions branch October 4, 2024 04:00
@github-actions github-actions bot added this to the 461 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

File based authentication fails if bcrypt passwords are prefixed with '$2b' instead of '$2y'
2 participants