Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document missing Iceberg properties #23777

Merged
merged 5 commits into from
Oct 18, 2024

Conversation

findinpath
Copy link
Contributor

Description

Documentation PR

@cla-bot cla-bot bot added the cla-signed label Oct 14, 2024
@findinpath findinpath self-assigned this Oct 14, 2024
docs/src/main/sphinx/object-storage/metastores.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/object-storage/metastores.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
session property is `remove_orphan_files_min_retention`.
- `7 DAYS`
* - `iceberg.idle-writer-min-file-size`
- Minimum data written by a single partition writer before it can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats an implementation details .. what is the effect to the user and why would they configure this. Also link to https://trino.io/docs/current/admin/properties.html#data-size

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#19649

@raunaqmorarka can you pls help me summarize to explain what this config is doing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It potentially helps to reduce memory usage for writes to partitioned tables #19649
It's very low level detail, i'm not sure there is a nicer way to explain it.

docs/src/main/sphinx/connector/iceberg.md Outdated Show resolved Hide resolved
docs/src/main/sphinx/object-storage/metastores.md Outdated Show resolved Hide resolved
@findinpath findinpath force-pushed the findinpath/docs-iceberg branch from d0e21f5 to 2f2e9ae Compare October 16, 2024 11:21
@findinpath findinpath requested a review from mosabua October 16, 2024 11:22
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. Thank you.

@mosabua mosabua merged commit e610f1c into trinodb:master Oct 18, 2024
8 checks passed
@github-actions github-actions bot added this to the 463 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants