Cleanup AggreggationNode#producesDistinctRows #23806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sopel39
approved these changes
Oct 18, 2024
| @@ -232,7 +232,8 @@ public boolean producesDistinctRows() | |||
| { | |||
| return aggregations.isEmpty() && | |||
| !groupingSets.getGroupingKeys().isEmpty() && | |||
| outputs.size() == groupingSets.getGroupingKeys().size(); | |||
| groupingSets.getGroupingSetCount() == 1 && | |||
There was a problem hiding this comment.
nit: consider adding comment why we need to check groupingSets.getGroupingSetCount() == 1
| @@ -232,7 +232,8 @@ public boolean producesDistinctRows() | |||
| { | |||
| return aggregations.isEmpty() && | |||
| !groupingSets.getGroupingKeys().isEmpty() && | |||
| outputs.size() == groupingSets.getGroupingKeys().size(); | |||
| groupingSets.getGroupingSetCount() == 1 && | |||
| outputs.size() == groupingSets.getGroupingKeys().size(); // grouping keys are always added to the outputs list, so a size match guarantees the two contain the same elements | |||
There was a problem hiding this comment.
note that this check is too strict when hash symbol is present. In most cases you don't really care about hash symbol being distinct. It's not a bit issue now that hash is off by default
There was a problem hiding this comment.
Good point- although that’s already been the case before your change, so not something I’ll worry about fixing here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds missing comment and check for the grouping count set as a follow up from #23776
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: