Reduce logging noise #23872
Merged
Reduce logging noise #23872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losipiuk
reviewed
Oct 23, 2024
| # Reduce levels of some known noisy loggers | ||
| org.eclipse.jetty=ERROR | ||
| org.glassfish.jersey.server.ServerRuntime$Responder=OFF | ||
| io.airlift.concurrent.BoundedExecutor=OFF |
There was a problem hiding this comment.
what does it produce, that we want to disable it?
There was a problem hiding this comment.
When it's shut down it rejects all of the tasks that log a bunch of errors.
losipiuk
approved these changes
Oct 23, 2024
hashhar
reviewed
Nov 18, 2024
| # Reduce levels of some known noisy loggers | ||
| org.eclipse.jetty=ERROR | ||
| org.glassfish.jersey.server.ServerRuntime$Responder=OFF | ||
| io.airlift.concurrent.BoundedExecutor=OFF |
There was a problem hiding this comment.
in production these logs will also show when bounded executor has failed (e.g. running out of process limits).
This change should only be limited to tests IMO, not wider than that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: