Support reading geometries in EWKB format.

[umartin]

Description

Add support for parsing EKWB format in ST_GeomFromBinary

Additional context and related issues

EWKB is a popular extension to WKB.
Closes #23824

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: Add support for EWKB in ST_GeomFromBinary

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[cla-bot]

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

[wendigo]

@umartin Instead of merge please rebase this PR

[ebyhr]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[wendigo]

Thanks @umartin

[umartin]

Thank you @wendigo!

[umartin]

Just to be cautious - is there a mechanism in Trino that prevents concurrent calls to geomFromBinary in the same JVM? Otherwise it is safer to create a new WKBReader instance for each call instead of a static instance.

"This class is designed to support reuse of a single instance to read multiple geometries. This class is not thread-safe; each thread should create its own instance."

https://locationtech.github.io/jts/javadoc/org/locationtech/jts/io/WKBReader.html

[martint]

It's possible, but it requires functions to be implemented as stateful functions. See

trino/plugin/trino-ml/src/main/java/io/trino/plugin/ml/MLFeaturesFunctions.java

Line 39 in d79e9be

public static class Features1

for an example.

The implementation in this PR is, therefore, not thread-safe.

[umartin]

Got it, thanks! I'll open another PR removing the static field.