-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iceberg.jdbc-catalog.retryable-status-codes configuration property #24066
Add iceberg.jdbc-catalog.retryable-status-codes configuration property #24066
Conversation
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you submit CLA?
Yes, I did, yesterday (11/07) so it may take a few days to get processed. |
0893180
to
bc6d206
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
bc6d206
to
28e2ed3
Compare
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
28e2ed3
to
886bf93
Compare
886bf93
to
4954893
Compare
Allows retrying additional, JDBC driver and database specific errors such as Postgres status codes `57000,57P03,57P04` if using Postgres.
4954893
to
8e25e5c
Compare
Allows retrying additional, JDBC driver and database specific errors
Add iceberg.jdbc-catalog.retryable-status-codes configuration property.such as Postgres status codes
57000,57P03,57P04
if using Postgres.Description
Iceberg JDBC catalog uses internal connection pool which supports retrying transient
connection errors which improves Iceberg catalog resilience.
By default, only a limited set of status codes is supported: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java#L50
These codes are database-agnostic and do not include database-specific transient errors.
To configure additional status codes, Iceberg JDBC Catalog supports
retryable_status_codes
configurationproperty: https://github.com/apache/iceberg/blob/main/core/src/main/java/org/apache/iceberg/jdbc/JdbcClientPool.java#L73
This PR adds this property to the Trino Iceberg catalog properties so it can be configured.
Additional context and related issues
Partially fixes #23095.
Release notes
(x) Release notes are required, with the following suggested text: