Move DirectTrinoClient to a non-testing package #24193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This originted in testing code, but it is being repurposed as a general-purpose utility, so it should not be in a `testing` package. The tests for this class are in the `testing/trino-tests` module in class `io.trino.tests.TestLocalQueries`, so they are not moved along with it.
wendigo
approved these changes
Nov 21, 2024
|
This doesn’t seem to have any uses other than in tests, so it should remain where it was. We don’t do “general purpose utilities” for out-of-tree projects to use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This originted in testing code, but it is being repurposed as a general-purpose utility, so it should not be in a
testingpackage.The tests for this class are in the
testing/trino-testsmodule in classio.trino.tests.TestLocalQueries, so they are not moved along with it.Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: