Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iceberg to product tests suite #3092

Merged
merged 2 commits into from
Apr 2, 2020
Merged

Add iceberg to product tests suite #3092

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd1d481
Add iceberg to product tests suite
vrozov Feb 6, 2020
01e4286
Temporarily exclude iceberg from Kerberos product tests
vrozov Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...t-tests-launcher/src/main/java/io/prestosql/tests/product/launcher/env/common/Hadoop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public final class Hadoop
implements EnvironmentExtender
{
public static final String CONTAINER_PRESTO_HIVE_PROPERTIES = CONTAINER_PRESTO_ETC + "/catalog/hive.properties";
public static final String CONTAINER_PRESTO_ICEBERG_PROPERTIES = CONTAINER_PRESTO_ETC + "/catalog/iceberg.properties";

private final DockerFiles dockerFiles;

Expand All @@ -56,7 +57,8 @@ public void extendEnvironment(Environment.Builder builder)
builder.addContainer("hadoop-master", createHadoopMaster());

builder.configureContainer("presto-master", container -> container
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY));
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY));
}

@SuppressWarnings("resource")
Expand Down
4 changes: 3 additions & 1 deletion ...launcher/src/main/java/io/prestosql/tests/product/launcher/env/environment/Multinode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.io.File;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Standard.CONTAINER_PRESTO_CONFIG_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Standard.CONTAINER_PRESTO_JVM_CONFIG;
import static io.prestosql.tests.product.launcher.env.common.Standard.createPrestoContainer;
Expand Down Expand Up @@ -78,7 +79,8 @@ private DockerContainer createPrestoWorker()
DockerContainer container = createPrestoContainer(dockerFiles, pathResolver, serverPackage, "prestodev/centos6-oj8:" + imagesVersion)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode/multinode-worker-jvm.config"), CONTAINER_PRESTO_JVM_CONFIG, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode/multinode-worker-config.properties"), CONTAINER_PRESTO_CONFIG_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY);
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY);

return container;
}
Expand Down
4 changes: 3 additions & 1 deletion ...ncher/src/main/java/io/prestosql/tests/product/launcher/env/environment/MultinodeTls.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import java.io.File;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Standard.CONTAINER_PRESTO_CONFIG_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Standard.CONTAINER_TEMPTO_PROFILE_CONFIG;
import static io.prestosql.tests.product.launcher.env.common.Standard.createPrestoContainer;
Expand Down Expand Up @@ -88,7 +89,8 @@ private void addPrestoWorker(Environment.Builder builder, String workerName)
.withCreateContainerCmdModifier(createContainerCmd -> createContainerCmd.withDomainName("docker.cluster"))
.withNetworkAliases(workerName + ".docker.cluster")
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls/config-worker.properties"), CONTAINER_PRESTO_CONFIG_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY);
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("common/hadoop/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY);

builder.addContainer(workerName, container);
}
Expand Down
7 changes: 5 additions & 2 deletions ...c/main/java/io/prestosql/tests/product/launcher/env/environment/MultinodeTlsKerberos.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

import static com.google.common.base.Verify.verify;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Standard.CONTAINER_PRESTO_CONFIG_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Standard.createPrestoContainer;
import static java.util.Objects.requireNonNull;
Expand Down Expand Up @@ -73,7 +74,8 @@ protected void extendEnvironment(Environment.Builder builder)
verify(Objects.equals(container.getDockerImageName(), prestoDockerImageName), "Expected image '%s', but is '%s'", prestoDockerImageName, container.getDockerImageName());
container
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/config-master.properties"), CONTAINER_PRESTO_CONFIG_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY);
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY);
});

addPrestoWorker(builder, "presto-worker-1");
Expand All @@ -87,7 +89,8 @@ private void addPrestoWorker(Environment.Builder builder, String workerName)
.withCreateContainerCmdModifier(createContainerCmd -> createContainerCmd.withDomainName("docker.cluster"))
.withNetworkAliases(workerName + ".docker.cluster")
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/config-worker.properties"), CONTAINER_PRESTO_CONFIG_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY);
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/multinode-tls-kerberos/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY);

builder.addContainer(workerName, container);
}
Expand Down
4 changes: 3 additions & 1 deletion ...java/io/prestosql/tests/product/launcher/env/environment/SinglenodeHdfsImpersonation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand All @@ -44,6 +45,7 @@ public SinglenodeHdfsImpersonation(DockerFiles dockerFiles, Standard standard, H
protected void extendEnvironment(Environment.Builder builder)
{
builder.configureContainer("presto-master", container -> container
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-hdfs-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY));
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-hdfs-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-hdfs-impersonation/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY));
}
}
4 changes: 3 additions & 1 deletion ...java/io/prestosql/tests/product/launcher/env/environment/SinglenodeHiveImpersonation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand All @@ -44,6 +45,7 @@ public SinglenodeHiveImpersonation(DockerFiles dockerFiles, Standard standard, H
protected void extendEnvironment(Environment.Builder builder)
{
builder.configureContainer("presto-master", container -> container
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-hive-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY));
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-hive-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-hive-impersonation/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY));
}
}
4 changes: 3 additions & 1 deletion ...prestosql/tests/product/launcher/env/environment/SinglenodeKerberosHdfsImpersonation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand All @@ -45,6 +46,7 @@ public SinglenodeKerberosHdfsImpersonation(DockerFiles dockerFiles, Standard sta
protected void extendEnvironment(Environment.Builder builder)
{
builder.configureContainer("presto-master", container -> container
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY));
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-impersonation/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY));
}
}
5 changes: 5 additions & 0 deletions ...tests/product/launcher/env/environment/SinglenodeKerberosHdfsImpersonationCrossRealm.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand All @@ -50,6 +51,10 @@ protected void extendEnvironment(Environment.Builder builder)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-impersonation-cross-realm/hive.properties"),
CONTAINER_PRESTO_HIVE_PROPERTIES,
READ_ONLY)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-impersonation-cross-realm/iceberg.properties"),
CONTAINER_PRESTO_ICEBERG_PROPERTIES,
READ_ONLY);
});
}
Expand Down
7 changes: 6 additions & 1 deletion ...oduct/launcher/env/environment/SinglenodeKerberosHdfsImpersonationWithWireEncryption.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand Down Expand Up @@ -62,7 +63,11 @@ protected void extendEnvironment(Environment.Builder builder)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-impersonation-with-wire-encryption/hive.properties"),
CONTAINER_PRESTO_HIVE_PROPERTIES,
READ_ONLY);
READ_ONLY)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-impersonation-with-wire-encryption/iceberg.properties"),
CONTAINER_PRESTO_ICEBERG_PROPERTIES,
READ_ONLY);
});
}
}
4 changes: 3 additions & 1 deletion ...estosql/tests/product/launcher/env/environment/SinglenodeKerberosHdfsNoImpersonation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand All @@ -45,6 +46,7 @@ public SinglenodeKerberosHdfsNoImpersonation(DockerFiles dockerFiles, Standard s
protected void extendEnvironment(Environment.Builder builder)
{
builder.configureContainer("presto-master", container -> container
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-no-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY));
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-no-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hdfs-no-impersonation/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY));
}
}
4 changes: 3 additions & 1 deletion ...prestosql/tests/product/launcher/env/environment/SinglenodeKerberosHiveImpersonation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand All @@ -45,6 +46,7 @@ public SinglenodeKerberosHiveImpersonation(DockerFiles dockerFiles, Standard sta
protected void extendEnvironment(Environment.Builder builder)
{
builder.configureContainer("presto-master", container -> container
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hive-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY));
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hive-impersonation/hive.properties"), CONTAINER_PRESTO_HIVE_PROPERTIES, READ_ONLY)
.withFileSystemBind(dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-hive-impersonation/iceberg.properties"), CONTAINER_PRESTO_ICEBERG_PROPERTIES, READ_ONLY));
}
}
5 changes: 5 additions & 0 deletions ...stosql/tests/product/launcher/env/environment/SinglenodeKerberosKmsHdfsImpersonation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand Down Expand Up @@ -63,6 +64,10 @@ protected void extendEnvironment(Environment.Builder builder)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-kms-hdfs-impersonation/hive.properties"),
CONTAINER_PRESTO_HIVE_PROPERTIES,
READ_ONLY)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-kms-hdfs-impersonation/iceberg.properties"),
CONTAINER_PRESTO_ICEBERG_PROPERTIES,
READ_ONLY);
});
}
Expand Down
5 changes: 5 additions & 0 deletions ...osql/tests/product/launcher/env/environment/SinglenodeKerberosKmsHdfsNoImpersonation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import javax.inject.Inject;

import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_HIVE_PROPERTIES;
import static io.prestosql.tests.product.launcher.env.common.Hadoop.CONTAINER_PRESTO_ICEBERG_PROPERTIES;
import static java.util.Objects.requireNonNull;
import static org.testcontainers.containers.BindMode.READ_ONLY;

Expand All @@ -51,6 +52,10 @@ protected void extendEnvironment(Environment.Builder builder)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-kms-hdfs-no-impersonation/hive.properties"),
CONTAINER_PRESTO_HIVE_PROPERTIES,
READ_ONLY)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/singlenode-kerberos-kms-hdfs-no-impersonation/iceberg.properties"),
CONTAINER_PRESTO_ICEBERG_PROPERTIES,
READ_ONLY);
});
}
Expand Down
10 changes: 10 additions & 0 deletions ...r/src/main/java/io/prestosql/tests/product/launcher/env/environment/TwoKerberosHives.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,16 @@ protected void extendEnvironment(Environment.Builder builder)
.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/two-kerberos-hives/hive2.properties"),
CONTAINER_PRESTO_ETC + "/catalog/hive2.properties",
READ_ONLY)

.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/two-kerberos-hives/iceberg1.properties"),
CONTAINER_PRESTO_ETC + "/catalog/iceberg1.properties",
READ_ONLY)

.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/two-kerberos-hives/iceberg2.properties"),
CONTAINER_PRESTO_ETC + "/catalog/iceberg2.properties",
READ_ONLY);
});

Expand Down
8 changes: 8 additions & 0 deletions ...cher/src/main/java/io/prestosql/tests/product/launcher/env/environment/TwoMixedHives.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,14 @@ protected void extendEnvironment(Environment.Builder builder)
dockerFiles.getDockerFilesHostPath("conf/environment/two-mixed-hives/hive2.properties"),
CONTAINER_PRESTO_ETC + "/catalog/hive2.properties",
READ_ONLY);
container.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/two-mixed-hives/iceberg1.properties"),
CONTAINER_PRESTO_ETC + "/catalog/iceberg1.properties",
READ_ONLY);
container.withFileSystemBind(
dockerFiles.getDockerFilesHostPath("conf/environment/two-mixed-hives/iceberg2.properties"),
CONTAINER_PRESTO_ETC + "/catalog/iceberg2.properties",
READ_ONLY);
});

builder.addContainer("hadoop-master-2", createHadoopMaster2());
Expand Down
4 changes: 4 additions & 0 deletions ...-launcher/src/main/resources/docker/presto-product-tests/common/hadoop/iceberg.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
connector.name=iceberg
hive.metastore.uri=thrift://hadoop-master:9083
hive.config.resources=/docker/presto-product-tests/conf/presto/etc/hive-default-fs-site.xml
iceberg.file-format=PARQUET
15 changes: 15 additions & 0 deletions ...es/docker/presto-product-tests/conf/environment/multinode-tls-kerberos/iceberg.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
connector.name=iceberg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to not to configure iceberg connector in environments where it does not work. That would be very misleading to other developers, where they would think where something just got broken because it does not work but it is committed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, there is a difference between committing broken functionality and providing a test environment that demonstrates that the functionality of a plugin is broken in certain configurations.

hive.metastore.uri=thrift://hadoop-master:9083
hive.config.resources=/docker/presto-product-tests/conf/presto/etc/hive-default-fs-site.xml

hive.metastore.authentication.type=KERBEROS
hive.metastore.service.principal=hive/hadoop-master@LABS.TERADATA.COM
hive.metastore.client.principal=hive/hadoop-master@LABS.TERADATA.COM
hive.metastore.client.keytab=/etc/hive/conf/hive.keytab

hive.hdfs.authentication.type=KERBEROS
hive.hdfs.impersonation.enabled=false
hive.hdfs.presto.principal=hdfs/hadoop-master@LABS.TERADATA.COM
hive.hdfs.presto.keytab=/etc/hadoop/conf/hdfs.keytab

iceberg.file-format=PARQUET
8 changes: 8 additions & 0 deletions ...er/presto-product-tests/conf/environment/singlenode-hdfs-impersonation/iceberg.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
connector.name=iceberg
hive.metastore.uri=thrift://hadoop-master:9083
hive.config.resources=/docker/presto-product-tests/conf/presto/etc/hive-default-fs-site.xml

hive.hdfs.authentication.type=NONE
hive.hdfs.impersonation.enabled=true

iceberg.file-format=PARQUET
Loading