Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a system table to list all ANALYZE properties #376

Conversation

kokosing
Copy link
Member

@kokosing kokosing commented Mar 4, 2019

Add a system table to list all ANALYZE properties

Extracted from: prestodb/presto#12409

@cla-bot
Copy link

cla-bot bot commented Mar 4, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.

@kokosing kokosing force-pushed the origin/master/100_port_12409_from_legacy_presto branch from 1fdac04 to 0c9e8b8 Compare March 4, 2019 19:42
@cla-bot
Copy link

cla-bot bot commented Mar 4, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.

Copy link
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like AnalyzePropertiesSystemTable got dropped from the cherry pick.

@@ -15,7 +15,9 @@ Description
Collects table and column statistics for a given table.

The optional ``WITH`` clause can be used to provide
connector-specific properties.
connector-specific properties. To list all available properties, run the following query::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original wrapping here is odd (likely overzealous in wrapping at 80 characters). Let's format like

The optional ``WITH`` clause can be used to provide connector-specific properties.
To list all available properties, run the following query::

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed as fixup.

@kokosing
Copy link
Member Author

kokosing commented Mar 7, 2019

It looks like AnalyzePropertiesSystemTable got dropped from the cherry pick.

No it is here: https://github.com/prestosql/presto/pull/376/files#diff-6c59c65cfaf7b10d2362cd0f444d0888R21. See also that travis is passing.

@cla-bot
Copy link

cla-bot bot commented Mar 7, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.

@kokosing kokosing force-pushed the origin/master/100_port_12409_from_legacy_presto branch from 2392f28 to d2cf082 Compare March 7, 2019 14:06
@cla-bot
Copy link

cla-bot bot commented Mar 7, 2019

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please submit the signed CLA to cla@prestosql.io. If you are contributing on behalf of someone else (e.g., your employer), the individual CLA may not be sufficient and your employer may need the Corporate CLA signed.

@kokosing kokosing closed this Mar 7, 2019
@kokosing kokosing deleted the origin/master/100_port_12409_from_legacy_presto branch March 7, 2019 14:06
@kokosing kokosing merged commit d2cf082 into trinodb:master Mar 7, 2019
@kokosing kokosing added this to the 305 milestone Mar 7, 2019
@kokosing kokosing mentioned this pull request Mar 7, 2019
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants