Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localtime in legacy timestamp semantics #3849

Conversation

findepi
Copy link
Member

@findepi findepi commented May 26, 2020

Fix localtime in legacy timestamp semantics when session zone has
different zone offset on current date compared to offset on 1970-01-01.

Fixes #3846
Fixes #3850

@findepi findepi requested a review from martint May 26, 2020 07:32
@cla-bot cla-bot bot added the cla-signed label May 26, 2020
findepi added 2 commits May 26, 2020 09:42
Fix `localtime` in legacy timestamp semantics when session zone has
different zone offset on current date compared to offset on 1970-01-01.
Fix `current_time` in legacy timestamp semantics when session zone has
different zone offset on current date compared to offset on 1970-01-01.
@findepi findepi force-pushed the findepi/master/fix-localtime-in-legacy-timestamp-semantics-167fb2 branch from 1e100fb to ea580b0 Compare May 26, 2020 07:42
@findepi
Copy link
Member Author

findepi commented May 28, 2020

CI failed -- #3161

@findepi findepi merged commit 4841ee0 into trinodb:master May 28, 2020
@findepi findepi deleted the findepi/master/fix-localtime-in-legacy-timestamp-semantics-167fb2 branch May 28, 2020 11:06
@findepi findepi mentioned this pull request May 28, 2020
8 tasks
@findepi findepi added this to the 334 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Incorrect value returned by current_time Incorrect value returned by localtime
2 participants