Fix ResultSet#getDate for dates before 1582 #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
approved these changes
Jun 11, 2020
martint
approved these changes
Jun 12, 2020
Fix `getTimestamp` for dates before 1582. Also, fix `getTimestamp` for dates where time zone rules observed by `java.util.Date` and Java Time differ (for some zones, this is as late as beginning of XX century). The `getTimestamp` overload accepting a `Calendar` remains not fixed.
findepi
force-pushed
the
findepi/master/fix-resultset-getdate-for-dates-before-1582-d39797
branch
from
49bfc3d to
e6bd612
Compare
findepi
deleted the
findepi/master/fix-resultset-getdate-for-dates-before-1582-d39797
branch
This was referenced Jun 12, 2020
Closed
|
FYI this got reverted, and i created #4018 as a follow up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.